-
Notifications
You must be signed in to change notification settings - Fork 16
build: update prost crates
#1426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
- Coverage 71.35% 71.29% -0.06%
==========================================
Files 413 413
Lines 66152 66142 -10
==========================================
- Hits 47203 47157 -46
- Misses 18949 18985 +36
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-01-09 18:04:12 Comparing candidate commit f63272d in PR branch Found 13 performance improvements and 2 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
scenario:normalization/normalize_service/normalize_service/[empty string]
scenario:profile_add_sample2_frames_x1000
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
|
CI failure was due to an interrupted syscall, which I adjusted to be handled here: #1430. |
morrisonlevi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure on the changelog process as it's new but as far as I can tell, it looks good.
|
After merging in tests, there was a SIGSEGV in |
|
@morrisonlevi I'm frightfully unfamiliar with development in this repo, would you mind helping me understand what I should do to move this forward? Should I ping the other teams listed to request reviews? |
|
I've been trying to get it to pass but CI keeps failing for "odd" reasons. Latest failure was a recent policy change though but I've fixed the title and 🤞🏻 it will work this time! |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
|
Thank you @morrisonlevi! |
What does this PR do?
Update the
prostandprost-buildcrates to 0.14.1. Updateconsole-subscriberto 0.5 to update its transitiveprostdependencies.Motivation
I was going through crate updates for single-machine-performance and noticed that we're pulling in
prost0.13 vialibdd-ddsketch. I had some time, so I thought I'd send an update.Notes
I worked my way through some CI failures, but I'm not sure if I should have. See 1d229c6, in response to https://github.com/DataDog/libdatadog/actions/runs/20479792813/job/58851067888. Generated with
cargo check -p libdd-trace-protobuf --features generate-protobuf.